Skip to content

Conversation

@ayushgnv
Copy link
Contributor

Description

With the upcoming release of Isaac Sim 4.5, this PR introduces updates to ensure the Isaac Panda tutorial remains current while maintaining backward compatibility with older versions of Isaac Sim.

Summary of Changes:

  • Updated logic to detect Isaac Sim 4.5 in its new installation path.
  • Adjusted import statements to accommodate renamed extensions and python modules introduced in Isaac Sim 4.5.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@henningkayser henningkayser self-requested a review January 24, 2025 12:35
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The changes look good to me overall. Unfortunately, I can't test this myself due to unmet hardware requirements. Approving anyway, since backwards compatibility is provided.

@henningkayser
Copy link
Member

@ayushgnv I'm merging these changes now to enable 4.5 support. Unfortunately, there is no simple solution to fix the docker image as the current main branch of moveit2_tutorials is not supporting Humble anymore due to conflicting dependencies. I tried different alternatives to manually build up the workspace with little success, mainly because the main (or ros2 branches) of the current dependencies don't support Humble. The problem is further described in this issue. I suggest moving the isaac_ros tutorial into the humble branch for continued support.

@henningkayser henningkayser merged commit 3e6de33 into moveit:main Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants