Skip to content

Fix two nodes launched with same name of /rivz2 #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sea-bass merged 2 commits into from
Apr 1, 2025
Merged

Fix two nodes launched with same name of /rivz2 #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89944a4
Add node name remap rule for rviz2
Juliaj Mar 31, 2025
df685ef
Update per review feedback
Juliaj Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...examples/jupyter_notebook_prototyping/jupyter_notebook_prototyping_tutorial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ Once our MoveIt configuration is defined we start the following set of nodes:
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/examples/jupyter_notebook_prototyping/launch/jupyter_notebook_prototyping.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/examples/motion_planning_python_api/launch/motion_planning_python_api_tutorial.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/examples/move_group_interface/launch/move_group.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/examples/moveit_cpp/launch/moveit_cpp_tutorial.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/examples/perception_pipeline/launch/perception_pipeline_demo.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/examples/realtime_servo/launch/pose_tracking_tutorial.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def generate_launch_description():
rviz_node = launch_ros.actions.Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
2 changes: 0 additions & 2 deletions doc/how_to_guides/chomp_planner/launch/chomp_demo.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def generate_launch_description():
rviz_node_tutorial = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_empty_config],
parameters=[
Expand All @@ -61,7 +60,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_full_config],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/isaac_panda/launch/isaac_demo.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/moveit_launch_files/moveit_launch_files_tutorial.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ The following code uses a launch argument to receive an RViz configuration file
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/parallel_planning/launch/parallel_planning_example.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ def launch_setup(context, *args, **kwargs):
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/persistent_scenes_and_states/launch/persistent_scenes_demo.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/pick_ik/launch/demo_pick_ik.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def launch_setup(context, *args, **kwargs):
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/pilz_industrial_motion_planner/launch/pilz_moveit.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/trajectory_cache/launch/trajectory_cache_move_group.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/how_to_guides/using_ompl_constrained_planning/launch/ompl_constrained_planning.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/tutorials/pick_and_place_with_moveit_task_constructor/launch/mtc_demo.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config_file],
parameters=[
Expand Down
1 change: 0 additions & 1 deletion doc/tutorials/quickstart_in_rviz/launch/demo.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def generate_launch_description():
rviz_node = Node(
package="rviz2",
executable="rviz2",
name="rviz2",
output="log",
arguments=["-d", rviz_config],
parameters=[
Expand Down
Loading