Skip to content

Conversation

@sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Apr 11, 2025

Description

This was causing build errors on a recent PR, and also who cares about this?

Error:

Warning, treated as error:
The analytics_id option is deprecated, use the sphinxcontrib-googleanalytics extension instead.

I feel like instead of figuring this out or pinning back the Sphinx version, it's best to reMoveIt!

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@mikeferguson
Copy link
Contributor

Perhaps @EzraBrooks can find out who owns the analytics account and can offer thoughts on this?

@sea-bass
Copy link
Contributor Author

Perhaps @EzraBrooks can find out who owns the analytics account and can offer thoughts on this?

Good point. Also tagging @nbbrooks in case you guys would prefer to fix this vs. remove it altogether.

Copy link
Contributor

@stephanie-eng stephanie-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to remove it for now to prevent errors, that's also OK by me. If there's desire to have it, we can restore when fixed.

@sea-bass
Copy link
Contributor Author

If we need to remove it for now to prevent errors, that's also OK by me. If there's desire to have it, we can restore when fixed.

I'm okay waiting a few days for an answer since the code side of things still works.

@sea-bass sea-bass merged commit c8e7944 into main Apr 15, 2025
9 checks passed
@sea-bass sea-bass deleted the remove-analytics branch April 15, 2025 14:21
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants