Skip to content

Conversation

@ashwinsnambiar
Copy link
Contributor

Description

This PR adds new documentation for the newly added controller_service_call_timeout, ROS parameter for ros_control controllers.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@ashwinsnambiar
Copy link
Contributor Author

Hi @sea-bass, as discussed I have added a few documentation for the new ROS parameter in move_it2

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashwinsnambiar! Could you split the sentences into separate lines just so it's different lines of "code" in the diffs? Else looks good.

@ashwinsnambiar
Copy link
Contributor Author

Thanks @ashwinsnambiar! Could you split the sentences into separate lines just so it's different lines of "code" in the diffs? Else looks good.

I've changed it.

@sea-bass sea-bass merged commit 2ecfb08 into moveit:main Apr 12, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants