Skip to content

Commit 07f62aa

Browse files
committed
add override in Task
I very much considered just removing the protected inheritance again, but it would add unnecessary code duplication. Take note, the overriding `insert` function bypasses the Wrapper and directly forwards to the wrapped container. This is somewhat dirty and could be an issue for anyone inheriting from `Task`.
1 parent 7cd82d5 commit 07f62aa

File tree

1 file changed

+2
-2
lines changed
  • core/include/moveit/task_constructor

1 file changed

+2
-2
lines changed

core/include/moveit/task_constructor/task.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ class Task : protected WrapperBase
8282
ContainerBase::pointer&& container = std::make_unique<SerialContainer>("task pipeline"));
8383
Task(Task&& other);
8484
Task& operator=(Task&& other);
85-
~Task();
85+
~Task() override;
8686

8787
const std::string& id() const;
8888

@@ -93,7 +93,7 @@ class Task : protected WrapperBase
9393
void loadRobotModel(const std::string& robot_description = "robot_description");
9494

9595
void add(Stage::pointer&& stage);
96-
bool insert(Stage::pointer&& stage, int before = -1);
96+
bool insert(Stage::pointer&& stage, int before = -1) override;
9797
void clear() final;
9898

9999
/// enable introspection publishing for use with rviz

0 commit comments

Comments
 (0)