Skip to content

Commit ad45a4f

Browse files
authored
Merge PR #746: fixups
- Fix .urdf and .srdf file names for panda robot - Fix broken links to MoveIt C++ API
2 parents 5dead36 + 79762de commit ad45a4f

File tree

9 files changed

+21
-18
lines changed

9 files changed

+21
-18
lines changed

conf.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@
8080
"moveit_core": (
8181
"http://docs.ros.org/"
8282
+ ros_distro
83-
+ "/api/moveit_core/html/cpp/classmoveit_1_1core_1_1%s.html",
83+
+ "/api/moveit_core/html/classmoveit_1_1core_1_1%s.html",
8484
"",
8585
),
8686
"planning_scene": (
8787
"http://docs.ros.org/"
8888
+ ros_distro
89-
+ "/api/moveit_core/html/cpp/classplanning__scene_1_1%s.html",
89+
+ "/api/moveit_core/html/classplanning__scene_1_1%s.html",
9090
"",
9191
),
9292
"planning_scene_monitor": (
@@ -98,23 +98,23 @@
9898
"collision_detection_struct": (
9999
"http://docs.ros.org/"
100100
+ ros_distro
101-
+ "/api/moveit_core/html/cpp/structcollision__detection_1_1%s.html",
101+
+ "/api/moveit_core/html/structcollision__detection_1_1%s.html",
102102
"",
103103
),
104104
"collision_detection_class": (
105105
"http://docs.ros.org/"
106106
+ ros_distro
107-
+ "/api/moveit_core/html/cpp/classcollision__detection_1_1%s.html",
107+
+ "/api/moveit_core/html/classcollision__detection_1_1%s.html",
108108
"",
109109
),
110110
"kinematic_constraints": (
111111
"http://docs.ros.org/"
112112
+ ros_distro
113-
+ "/api/moveit_core/html/cpp/classkinematic__constraints_1_1%s.html",
113+
+ "/api/moveit_core/html/classkinematic__constraints_1_1%s.html",
114114
"",
115115
),
116116
"moveit_core_files": (
117-
"http://docs.ros.org/" + ros_distro + "/api/moveit_core/html/cpp/%s.html",
117+
"http://docs.ros.org/" + ros_distro + "/api/moveit_core/html/%s.html",
118118
"",
119119
),
120120
"moveit_website": ("http://moveit.ros.org/%s/", ""),

doc/bullet_collision_checker/launch/bullet_collision_checker_tutorial.launch

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
<launch>
22

33
<!-- load URDF -->
4-
<param name="robot_description" command="$(find xacro)/xacro '$(find franka_description)/robots/panda_arm.urdf.xacro hand:=true'" />
4+
<param name="robot_description"
5+
command="$(find xacro)/xacro '$(find franka_description)/robots/panda/panda.urdf.xacro hand:=true'"/>
56

67
<!-- load SRDF -->
7-
<param name="robot_description_semantic" command="$(find xacro)/xacro '$(find panda_moveit_config)/config/panda_arm_hand.srdf.xacro'" />
8+
<param name="robot_description_semantic" command="$(find xacro)/xacro '$(find panda_moveit_config)/config/panda.srdf.xacro'"/>
89

910
<!-- Run RViz with a custom config -->
1011
<node name="$(anon rviz)" pkg="rviz" type="rviz" respawn="false" args="-d $(find moveit_tutorials)/doc/bullet_collision_checker/launch/moveit.rviz" output="screen">

doc/gazebo_simulation/gazebo_simulation.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ the procedure outlined in there will be repeated (with improvements) in here as
2727

2828
1. Fix the robot to the world coordinate system
2929
-----------------------------------------------
30-
Open the :code:`franka_description/robots/panda_arm.urdf.xacro` file and change the line 5 with:
30+
Open the :code:`franka_description/robots/panda/panda.urdf.xacro` file and change the line 5 with:
3131

3232
.. code-block:: xml
3333
3434
<xacro:panda_arm xyz="0 0 0" rpy="0 0 0" connected_to="world"/>
3535
3636
It alone doesn't fix the problem, since now we need to provide a link with name :code:`world`. Add the following line to
37-
:code:`franka_description/robots/panda_arm.urdf.xacro`:
37+
:code:`franka_description/robots/panda/panda.urdf.xacro`:
3838

3939
.. code-block:: xml
4040
@@ -306,7 +306,7 @@ with :code:`<param name="robot_description" textfile="$(arg urdf_path)" />` and
306306

307307
.. code-block:: xml
308308
309-
<param name="robot_description" command="$(find xacro)/xacro '$(find franka_description)/robots/panda_arm.urdf.xacro'"/>
309+
<param name="robot_description" command="$(find xacro)/xacro '$(find franka_description)/robots/panda/panda.urdf.xacro'"/>
310310
311311
312312
With this adjustment we are using :code:`xacro` executable that compiles :code:`xacro` files into URDF files.

doc/motion_planning_api/src/motion_planning_api_tutorial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ int main(int argc, char** argv)
173173
// package.
174174
//
175175
// .. _kinematic_constraints:
176-
// http://docs.ros.org/noetic/api/moveit_core/html/cpp/namespacekinematic__constraints.html#a88becba14be9ced36fefc7980271e132
176+
// http://docs.ros.org/noetic/api/moveit_core/html/namespacekinematic__constraints.html#a88becba14be9ced36fefc7980271e132
177177
moveit_msgs::Constraints pose_goal =
178178
kinematic_constraints::constructGoalConstraints("panda_link8", pose, tolerance_pose, tolerance_angle);
179179

doc/motion_planning_pipeline/src/motion_planning_pipeline_tutorial.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ int main(int argc, char** argv)
150150
// package.
151151
//
152152
// .. _kinematic_constraints:
153-
// http://docs.ros.org/noetic/api/moveit_core/html/cpp/namespacekinematic__constraints.html#a88becba14be9ced36fefc7980271e132
153+
// http://docs.ros.org/noetic/api/moveit_core/html/namespacekinematic__constraints.html#a88becba14be9ced36fefc7980271e132
154154
req.group_name = "panda_arm";
155155
moveit_msgs::Constraints pose_goal =
156156
kinematic_constraints::constructGoalConstraints("panda_link8", pose, tolerance_pose, tolerance_angle);

doc/planning_scene/launch/planning_scene_tutorial.launch

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<launch>
22
<!-- send Panda urdf to parameter server -->
3-
<param name="robot_description" command="$(find xacro)/xacro '$(find franka_description)/robots/panda_arm.urdf.xacro' hand:=true" />
3+
<param name="robot_description"
4+
command="$(find xacro)/xacro '$(find franka_description)/robots/panda/panda.urdf.xacro' hand:=true"/>
45

56
<include file="$(find panda_moveit_config)/launch/planning_context.launch"/>
67

doc/planning_with_approximated_constraint_manifolds/planning_with_approximated_constraint_manifolds_tutorial.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ VisibilityConstraint
9898

9999
A ``VisibilityConstraint`` allows to eg. specify a camera should always be able to see the gripper.
100100

101-
How this is achieved is best explained by the `VisibilityConstraint <https://docs.ros.org/noetic/api/moveit_core/html/cpp/classkinematic__constraints_1_1VisibilityConstraint.html#details>`_ class documentation.
101+
How this is achieved is best explained by the `VisibilityConstraint <https://docs.ros.org/noetic/api/moveit_core/html/classkinematic__constraints_1_1VisibilityConstraint.html#details>`_ class documentation.
102102

103103
Such a constraint is compactly defined like this::
104104

doc/setup_assistant/setup_assistant_tutorial.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Step 1: Start
5252
* Click on the browse button and navigate to the *panda_arm.urdf.xacro* file
5353
installed when you installed the Franka package above. (This file
5454
gets installed in
55-
/opt/ros/noetic/share/franka_description/robots/panda_arm.urdf.xacro on Ubuntu
55+
/opt/ros/noetic/share/franka_description/robots/panda/panda.urdf.xacro on Ubuntu
5656
with ROS Noetic.) Choose that file and then click *Load Files*. The
5757
Setup Assistant will load the files (this might take a few seconds)
5858
and present you with this screen:

doc/visualizing_collisions/launch/visualizing_collisions_tutorial.launch

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
<launch>
22

33
<!-- load URDF -->
4-
<param name="robot_description" command="$(find xacro)/xacro '$(find franka_description)/robots/panda_arm.urdf.xacro' hand:=true" />
4+
<param name="robot_description"
5+
command="$(find xacro)/xacro '$(find franka_description)/robots/panda/panda.urdf.xacro' hand:=true"/>
56

67
<!-- load SRDF -->
7-
<param name="robot_description_semantic" command="$(find xacro)/xacro '$(find panda_moveit_config)/config/panda_arm_hand.srdf.xacro'"/>
8+
<param name="robot_description_semantic" command="$(find xacro)/xacro '$(find panda_moveit_config)/config/panda.srdf.xacro'"/>
89

910
<!-- Run RViz with a custom config -->
1011
<node name="$(anon rviz)" pkg="rviz" type="rviz" respawn="false"

0 commit comments

Comments
 (0)