Skip to content

Conversation

andygolay
Copy link

@andygolay andygolay commented Apr 14, 2025

Description

Type of Change

  • New feature

  • [ x] Bug fix

  • Breaking change

  • Performance improvement

  • Refactoring

  • Dependency update

  • Documentation update

  • Tests

  • Downgrade bigdecimal to version 0.3.0.

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • [ x] Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

  • cargo check --all-targets passes.
  • cargo test has same results as on movement branch.
  • movement move test passes in aptos-move/framework/aptos-framework/sources.

Key Areas to Review

Checklist

  • [ x] I have read and followed the CONTRIBUTING doc
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I identified and added all stakeholders and component owners affected by this change as reviewers
  • [ x] I tested both happy and unhappy path of the functionality
  • [ x] I have made corresponding changes to the documentation

@andygolay
Copy link
Author

andygolay commented Apr 14, 2025

Putting in draft because although cargo check --all-targets passes, I noticed what appear to be errors in some indexer files after downgrading bigdecimal, eg:

[{
	"resource": ".../aptos-core/crates/indexer/src/models/coin_models/coin_activities.rs",
	"owner": "rustc",
	"code": {
		"value": "Click for full compiler diagnostic",
		"target": {
			"$mid": 1,
			"path": "/diagnostic message [7]",
			"scheme": "rust-analyzer-diagnostics-view",
			"query": "7",
			"fragment": "file:///Users/andygmove/Downloads/repos/aptos-core/crates/indexer/src/models/coin_models/coin_activities.rs"
		}
	},
	"severity": 8,
	"message": "the trait bound `bigdecimal::BigDecimal: diesel::Expression` is not satisfied\nthe following other types implement trait `diesel::Expression`:\n  Box<T>\n  diesel_migrations::migration_harness::__diesel_schema_migrations::columns::run_on\n  diesel_migrations::migration_harness::__diesel_schema_migrations::columns::version\n  diesel_migrations::migration_harness::__diesel_schema_migrations::columns::star\n  diesel::expression::ops::numeric::Add<Lhs, Rhs>\n  diesel::expression::ops::numeric::Sub<Lhs, Rhs>\n  diesel::expression::ops::numeric::Mul<Lhs, Rhs>\n  diesel::expression::ops::numeric::Div<Lhs, Rhs>\nand 688 others\nrequired for `&'insert bigdecimal::BigDecimal` to implement `diesel::Expression`\nrequired for `&'insert bigdecimal::BigDecimal` to implement `AsExpression<diesel::sql_types::Numeric>`",
	"source": "rustc",
	"startLineNumber": 55,
	"startColumn": 9,
	"endLineNumber": 55,
	"endColumn": 15
}]

@andygolay andygolay changed the title fix: bigdecimal version for num-bigint compatibility feat: precompiled binaries for movement package Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant