Skip to content

Conversation

l-monninger
Copy link

Description

Attempt to validate:

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@l-monninger l-monninger changed the title Ci/build feat: ci/cd build Apr 28, 2025
@andygolay
Copy link

@l-monninger this adds arm64 builds? I see this is docker/kind/Dockerfile:

# Use this Dockerfile to build a custom kind image with a specific kubernetes version
# Note the usage of --platform=arm64, to ensure it works on M1 Mac

# Somehow this doesn't work for 1.24, but works for 1.23
# FROM --platform=arm64 kindest/node:v1.24.13@sha256:c9e00e2b228e47ba3c96eaf0309b27dc3f73e444944e4c900016fd07b1b805cb

FROM --platform=arm64 kindest/node:v1.23.17@sha256:2dd8f45f8a00b559af35583b7c95ab0e289843b0dce1d4906bb6a2c0fe983056
RUN arch

but that's already present on both the movement and main branches... so I'm wondering what needs to be added in this PR to support arm64 builds?

@l-monninger
Copy link
Author

@l-monninger this adds arm64 builds? I see this is docker/kind/Dockerfile:

# Use this Dockerfile to build a custom kind image with a specific kubernetes version
# Note the usage of --platform=arm64, to ensure it works on M1 Mac

# Somehow this doesn't work for 1.24, but works for 1.23
# FROM --platform=arm64 kindest/node:v1.24.13@sha256:c9e00e2b228e47ba3c96eaf0309b27dc3f73e444944e4c900016fd07b1b805cb

FROM --platform=arm64 kindest/node:v1.23.17@sha256:2dd8f45f8a00b559af35583b7c95ab0e289843b0dce1d4906bb6a2c0fe983056
RUN arch

but that's already present on both the movement and main branches... so I'm wondering what needs to be added in this PR to support arm64 builds?

I'm going to have to take a deeper look at their bake script. They are shipping unkown/unknown when we use it this way currently. I don't see the same thing in their Docker org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants