Skip to content

Conversation

andygolay
Copy link

Description

Attempting to solve diesel version mismatch issue in movementlabsxyz/movement#1264

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@larryl3u
Copy link

looks good. I took some thoughts:

I think there are two ways down the road, we patch our movement repo like you sid or we fork their sdk/processor.

TBH, i don't see a reason why they pin diesel to 2.2.0(we can nudge them to upgrade?). To unlock here, i propose we use forked sdk and processor since we are doing monorepo way i.e., we use a single rust workspace to unbrella all components and all versions should be compatible, which Aptos Labs don't care.

lmkwdyt!

@andygolay
Copy link
Author

looks good. I took some thoughts:

I think there are two ways down the road, we patch our movement repo like you sid or we fork their sdk/processor.

TBH, i don't see a reason why they pin diesel to 2.2.0(we can nudge them to upgrade?). To unlock here, i propose we use forked sdk and processor since we are doing monorepo way i.e., we use a single rust workspace to unbrella all components and all versions should be compatible, which Aptos Labs don't care.

lmkwdyt!

Yes I was also wondering about why they pin that specific diesel version. If you think using the forked SDK and processor is a good way forward, that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants