-
Notifications
You must be signed in to change notification settings - Fork 25
feature: add transaction getter to validation-tool #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: l1-migration
Are you sure you want to change the base?
Conversation
let str = format!("{}\n", hex::encode(&bytes)); | ||
writer.write_all(str.as_bytes()).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you use lines to read the file, perhaps you should use writeln!
macro to avoid managing the \n ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using tokio
for the async interface, and unfortunately, no writeln!
macro is available.
What's the status of this PR, there are some conflicts before it can merge. |
As discussed today, we need to check which parts of this PR are still required. We now want a tool that reads new transactions from the da-sequencer and replays them on the validator node. |
Description
Also, refactor the
api
command to a subcommand so that every tool can be run independently.How Has This Been Tested?
waypoint.txt
file for the ledger version../target/debug/validation-tool api transactions --url http://0.0.0.0:8080 --start 19332568 --out ~/tmp/transactions.bin
./target/debug/validation-tool api compare-transactions --url http://0.0.0.0:8080 --in ~/tmp/transactions.bin
Caution
I haven't tested the transaction comparison against one of our mainnet nodes yet.
However, such a test could face issues with Cloudflare's rate limiting.
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist