Skip to content

Conversation

larryl3u
Copy link

@larryl3u larryl3u commented Sep 4, 2025

Add Docker Build GitHub Actions Workflow

This PR adds a GitHub Actions workflow to build and push Docker images for the Movement
blockchain components.

Changes

  • New workflow: .github/workflows/docker-build.yml with multiple triggers:
    • Manual dispatch (any branch/tag)
    • Push to main, movement, ci/* branches
    • Tag pushes (v*, release-*)
    • PR label trigger (movement-docker-build)

Fixes Applied

  • Updated package references from aptos to movement
  • Removed outdated package version pins in Dockerfiles
  • Removed non-existent components (NFT metadata crawler, indexer-grpc)
  • Configured to push images to GitHub Container Registry (ghcr.io/movementlabsxyz/)

Usage

  • Manual: Run workflow from Actions tab, specify any branch/tag
  • PR builds: Add movement-docker-build label to trigger build
  • Auto: Pushes to main branches automatically build

Built images will be available at ghcr.io/movementlabsxyz/{component}:{tag} for Kubernetes
deployments.

@larryl3u larryl3u force-pushed the add-ci-docker-build branch from cc1f34f to f4840e2 Compare September 5, 2025 00:53
@larryl3u larryl3u changed the title update build. [ci] Add node build github action Sep 5, 2025
- Update generate_tags function to use ghcr.io/${GHCR_ORG}/ instead of hardcoded aptos-core
- All images now push to ghcr.io/movementlabsxyz/{component}:{tag}
- Fixes push access denied errors
- Add missing GHCR_ORG variable declaration
- This variable is used in generate_tags function for GitHub Container Registry
- Fixes 'variable GHCR_ORG does not exist' error
areshand
areshand previously approved these changes Sep 5, 2025
Copy link

@areshand areshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there is authorization error when pushing images. But the PR lgtm overall

- Remove from docker-bake-rust-all.hcl all targets group
- Remove target definition
- Remove from build-tools.sh cargo build and BINS array
- This component is not used by Movement
- Change TARGET_REGISTRY from 'ghcr.io' to 'local'
- 'local' is the intended value that triggers ghcr.io path in generate_tags
- Ensures all images push only to ghcr.io/movementlabsxyz/
- Add id-token: write permission for OIDC auth to GitHub Container Registry
- This may help resolve permission_denied errors when pushing packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants