Skip to content

[protocol] pcp kurtosis testing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

[protocol] pcp kurtosis testing #1

wants to merge 36 commits into from

Conversation

l-monninger
Copy link
Contributor

@l-monninger l-monninger commented Mar 7, 2025 •
edited by apenzk
Loading

Summary

  • Categories: protocol, cli

  • provide code for kurtosis testing

Changelog

Testing

  • forge test ok

Outstanding issues

@l-monninger l-monninger mentioned this pull request Mar 7, 2025
Open
@apenzk apenzk changed the title Post-confirmations Postconfirmations Mar 7, 2025
@apenzk apenzk changed the title Postconfirmations [protocol] postconfirmation protocol Mar 18, 2025
l-monninger
l-monninger commented Mar 19, 2025
View reviewed changes
protocol/mcr/cli/client/src/cli/mod.rs Outdated
PostCommitment(PostCommitmentArgs),
}

#[derive(clap::Args)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please following the structure of other CLI subcommands, moving this into a separate module.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR serves as reference, but may or may not get merged. It still caries information in regards to kurtosis, which is a reason to keep it for now. Most changes on pcp and some client changes have already been merged to main.

protocol/pcp/cli/client/src/send_eth_transaction.rs
fn verify(&self, error: &alloy_contract::Error) -> Result<bool, PcpEthConnectorError>;
}

pub struct SendTransactionErrorRule<Kind> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will want to copy over the more recent version of the of MCR structure. This should be under clients/eth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment. the mrc structure has been copied over and which is reflected on main

@l-monninger
Copy link
Contributor Author

  1. anvil: will start the anvil network
  2. Use the first address and private key as the deployer, call this signer_a. Use the second address and private key as the contract admin, call this signer_b.
  3. export PRIVATE_KEY=<signer_a_private_key>. Then, from the contracts directory run: ../anvil/scripts/depoy-dev.sh <signer_b_address> with defaults it should be appropriately deploying to anvil.
  4. Then run your CLI using signer_b as the signer.

@apenzk apenzk changed the title [protocol] postconfirmation protocol [protocol] postconfirmation protocol + client Mar 20, 2025
@apenzk apenzk changed the base branch from main to feat/pcp-adds-content March 20, 2025 14:49
@apenzk apenzk changed the base branch from feat/pcp-adds-content to main March 20, 2025 14:58
@apenzk apenzk changed the title [protocol] postconfirmation protocol + client [protocol] pcp kurtosis testing Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apenzk apenzk apenzk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-monninger @apenzk