Skip to content

Conversation

l-monninger
Copy link
Contributor

@l-monninger l-monninger commented Jun 12, 2025

Summary

Provides initial structure of the Environments API as prompted in #150 and an implementation for the testing environment.

You can see this in action with the CLI and the select API by running the mtma-migrate-node migrate select command:

# there are no -- --environment-testing.* args because the corresponding config currently doesn't require any
mtma-migrate-node migrate select --environment-testing --null 

Tip

The flag --environment-testing.* is the inverse naming of the struct TestingEnvironment intentionally. It is meant to convey the sense that you are selecting amongst several environments which would be prefixed --environment-*.

Warning

I did not add any additional tests because the logic for assembling the testing environment is identical to what is already tested. However, it would be a good idea to refactor tests to use the Environments API in which case it would also be good to write build_movement_migrator test.

I would suggest an issue and follow-on PR.

Note

I have also provided structure for the box and provisioner environments and an example of the how the select API is used to handle choosing one Environment. But, I have left them unimplemented.

PRs involved

@l-monninger l-monninger changed the base branch from main to l-monninger/mtma-select-null-migration June 12, 2025 05:51
Copy link
Collaborator

@andygolay andygolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-monninger with

mtma-migrate-node migrate select --environment-testing --null 

I'm getting

 streaming DA blobs between heights 16 and 17
movement-full-node               | 2025-06-12T16:54:55.649597Z  INFO movement_full_node::node::tasks::execute_settle: Receive DA heartbeat
Gracefully stopping... (press Ctrl+C again to force)
Error response from daemon: no container with ID 0621090da55d000647aec28338ea184a13acf946902a8ad81dc5ece23150127d found in database: no such container
error: Recipe `movement-full-node` failed on line 6 with exit code 1

Any idea what the cause might be?

I recall we had this error before but don't remember what the fix was.

@l-monninger
Copy link
Contributor Author

@l-monninger with

mtma-migrate-node migrate select --environment-testing --null 

I'm getting

 streaming DA blobs between heights 16 and 17
movement-full-node               | 2025-06-12T16:54:55.649597Z  INFO movement_full_node::node::tasks::execute_settle: Receive DA heartbeat
Gracefully stopping... (press Ctrl+C again to force)
Error response from daemon: no container with ID 0621090da55d000647aec28338ea184a13acf946902a8ad81dc5ece23150127d found in database: no such container
error: Recipe `movement-full-node` failed on line 6 with exit code 1

Any idea what the cause might be?

I recall we had this error before but don't remember what the fix was.

@andygolay

This is the correct behavior. It's just the logs from when kestrel::end triggers a shutdown of the containers.

Copy link
Collaborator

@andygolay andygolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l-monninger
Copy link
Contributor Author

@andygolay I'm going to leave this open until a get a few more eyes on.

@andygolay
Copy link
Collaborator

@andygolay I'm going to leave this open until a get a few more eyes on.

@andygolay I'm going to leave this open until a get a few more eyes on.

Sounds good, reviewing #155 now, probably best to merge that first too before this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants