-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Environments API #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: l-monninger/mtma-select-null-migration
Are you sure you want to change the base?
feat: Environments API #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l-monninger with
mtma-migrate-node migrate select --environment-testing --null
I'm getting
streaming DA blobs between heights 16 and 17
movement-full-node | 2025-06-12T16:54:55.649597Z INFO movement_full_node::node::tasks::execute_settle: Receive DA heartbeat
Gracefully stopping... (press Ctrl+C again to force)
Error response from daemon: no container with ID 0621090da55d000647aec28338ea184a13acf946902a8ad81dc5ece23150127d found in database: no such container
error: Recipe `movement-full-node` failed on line 6 with exit code 1
Any idea what the cause might be?
I recall we had this error before but don't remember what the fix was.
feat: add unused dependency checks to pre-commit hook
This is the correct behavior. It's just the logs from when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andygolay I'm going to leave this open until a get a few more eyes on. |
Sounds good, reviewing #155 now, probably best to merge that first too before this. |
Summary
Provides initial structure of the Environments API as prompted in #150 and an implementation for the
testing
environment.You can see this in action with the CLI and the select API by running the
mtma-migrate-node migrate select
command:Tip
The flag
--environment-testing.*
is the inverse naming of the structTestingEnvironment
intentionally. It is meant to convey the sense that you are selecting amongst several environments which would be prefixed--environment-*
.Warning
I did not add any additional tests because the logic for assembling the testing environment is identical to what is already tested. However, it would be a good idea to refactor tests to use the Environments API in which case it would also be good to write
build_movement_migrator
test.I would suggest an issue and follow-on PR.
Note
I have also provided structure for the
box
andprovisioner
environments and an example of the how the select API is used to handle choosing one Environment. But, I have left them unimplemented.PRs involved