feat: all ledger versions check #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing subset equals which is perhaps a bigger deal if we want to have this kind of faithfulness.
l-monninger
changed the title
|
The code looks good. However, checking against all ledger versions may take a long time, and the process may be even longer if we include the right-sided check. |
|
Yeah, I'll merge it into |
|
@l-monninger Are we still considering running this costly check? |
andygolay
changed the base branch from
l-monninger/movement-mainnet-checks
to
main
andygolay
changed the base branch from
main
to
l-monninger/movement-mainnet-checks
|
@l-monninger @sebtomba if this stays open, do we want to rebase against |
Yeah, I am working on fixing #49 which then opens up some better approaches here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a check against all ledger versions for left sided inclusion. As the last commit message says, if we really need to check at all ledger versions, inclusion probably isn't a good criterion--that level of fidelity probably means we want equality. So, likely we will want to add a ride-sided check as well.