Skip to content

Conversation

@njbrake
Copy link
Contributor

@njbrake njbrake commented Jan 29, 2026

Description

Consolidates the XML parsing logic to reduce code duplication

PR Type

  • 💅 Refactor

Relevant issues

Checklist

  • I understand the code I am submitting.
  • I have added unit tests that prove my fix/feature works
  • I have run this code locally and verified it fixes the issue.
  • New and existing tests pass locally
  • Documentation was updated where necessary
  • I have read and followed the contribution guidelines
  • AI Usage:
    • No AI was used.
    • AI was used for drafting/refactoring.
    • This is fully AI-generated.

AI Usage Information

  • AI Model used: Opus 4.5
  • AI Developer Tool used: Claude Code + AoE
  • Any other info you'd like to share: At first claude insisted on backwards compatibility (aka not removing any utils files but using those files to just re-export the now shared util. I told it to delete the files.

When answering questions by the reviewer, please respond yourself, do not copy/paste the reviewer comments into an AI system and paste back its answer. We want to discuss with you, not your AI :)

@codecov
Copy link

codecov bot commented Jan 29, 2026

Comment on lines -219 to +221
endpoint=endpoint,
endpoint=valid_endpoint,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistral released an SDK update yestereday that broke out type here

@njbrake
Copy link
Contributor Author

njbrake commented Jan 29, 2026

@njbrake njbrake linked an issue Jan 29, 2026 that may be closed by this pull request
@njbrake njbrake requested review from daavoo and tbille January 29, 2026 19:12
@njbrake njbrake requested review from tbille and removed request for daavoo January 30, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move xml parsing logic for reasoning content into shared location

3 participants