Merged
Conversation
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
1 task
1 task
daavoo
reviewed
Feb 10, 2025
| - OS: Windows, macOS, or Linux | ||
| - Python 3.10+ / 3.12+ for Apple M chips | ||
| - Minimum RAM: 8 GB | ||
| - Disk space: 20 GB minimum |
Contributor
There was a problem hiding this comment.
Where are the 20GB coming from?
Contributor
Author
There was a problem hiding this comment.
Well I thought venv is ~7GB, bartowski/Qwen2.5-7B-Instruct-GGUF/Qwen2.5-7B-Instruct-Q8_0.gguf is also ~8Gb, kokoro is lets say ~1GB, and then some slack space for loading the doc and stuff? 😅 As you see my method is very scientific... do you have any other suggestions?
Contributor
There was a problem hiding this comment.
No suggestions. It just sounds like more than I expected. Is the 7GB venv size with the CUDA version or the CPU version of torch? Anyway, not a blocker
daavoo
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
Add hardware requirements to README.
Closes #102
How to test it
Steps to test the changes:
Additional notes for reviewers
Testing it on a 16GB RAM machine in GitHub Codespaces shows that 8GB should be enough.
I already...
/docs)