Skip to content

Conversation

@henfiber
Copy link
Contributor

@henfiber henfiber commented Jun 1, 2025

The new server implementation (--v2) does not set the "Access-Control-Allow-Origin" header leading to CORS errors in applications (encountered while using an Obsidian extension).

The v1 server version does this:

res.set_header("Access-Control-Allow-Origin", req.get_header_value("Origin"));

Applied the same logic to the v2 server and tested that the header is properly set and CORS is allowed.

@cjpais
Copy link
Collaborator

cjpais commented Jun 30, 2025

@jart, do you think this is a reasonable default for the v2 server. I think it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants