Add missing llama.cpp sampling arguments #715 #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for missing llama.cpp sampling arguments --min-p and --top-k to llamafile.
Problem
Issue #715 reported that llamafile was missing several sampling arguments available in llama.cpp:
These arguments are needed for models like QwQ-32B to prevent response looping.
Implementation
Following llamafile's established patterns:
Command Line Arguments:
API Integration:
Files Changed
Testing
Added comprehensive tests covering:
Usage Examples
Command Line:
API Request:
{ "model": "model.gguf", "prompt": "Hello", "min_p": 0.05, "top_k": 40 }Notes
Resolves #715