Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/config/args/remove.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ func (c *RemoveCmd) run(cmd *cobra.Command, args []string) error {

if _, err := fmt.Fprintf(
cmd.OutOrStdout(),
"✓ Arguments removed for server '%s' (operation: %s): %v\n", serverName, string(res), slices.Collect(maps.Keys(argMap)),
"✓ Arguments removed for server '%s' (operation: %s): %v\n",
serverName,
string(res),
slices.Collect(maps.Keys(argMap)),
); err != nil {
return err
}
Expand Down
6 changes: 5 additions & 1 deletion cmd/config/args/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ func (c *SetCmd) run(cmd *cobra.Command, args []string) error {

if _, err := fmt.Fprintf(
cmd.OutOrStdout(),
"✓ Startup arguments %s for server '%s' (operation: %s): %v\n", operation, serverName, string(res), normalizedArgs,
"✓ Startup arguments %s for server '%s' (operation: %s): %v\n",
operation,
serverName,
string(res),
normalizedArgs,
); err != nil {
return err
}
Expand Down
5 changes: 4 additions & 1 deletion cmd/config/env/remove.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ func (c *RemoveCmd) run(cmd *cobra.Command, args []string) error {

if _, err := fmt.Fprintf(
cmd.OutOrStdout(),
"✓ Environment variables removed for server '%s' (operation: %s): %v\n", serverName, string(res), slices.Collect(maps.Keys(envMap)),
"✓ Environment variables removed for server '%s' (operation: %s): %v\n",
serverName,
string(res),
slices.Collect(maps.Keys(envMap)),
); err != nil {
return err
}
Expand Down
5 changes: 4 additions & 1 deletion cmd/config/env/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ func (c *SetCmd) run(cmd *cobra.Command, args []string) error {

if _, err := fmt.Fprintf(
cmd.OutOrStdout(),
"✓ Environment variables set for server '%s' (operation: %s): %v\n", serverName, string(res), slices.Collect(maps.Keys(envMap)),
"✓ Environment variables set for server '%s' (operation: %s): %v\n",
serverName,
string(res),
slices.Collect(maps.Keys(envMap)),
); err != nil {
return err
}
Expand Down
20 changes: 10 additions & 10 deletions cmd/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -1060,43 +1060,43 @@ func (c *DaemonCmd) formatConfigInfo(addr string) string {

// API configuration (only show if non-default).
if addr != "" && addr != "0.0.0.0:8090" {
info.WriteString(fmt.Sprintf(" API address:\t%s\n", addr))
fmt.Fprintf(&info, " API address:\t%s\n", addr)
}

// CORS configuration.
if c.config.cors.enable {
info.WriteString(fmt.Sprintf(" CORS enabled:\t%v (origins: %s)\n",
fmt.Fprintf(&info, " CORS enabled:\t%v (origins: %s)\n",
c.config.cors.enable,
strings.Join(c.config.cors.origins, ", ")))
strings.Join(c.config.cors.origins, ", "))

if len(c.config.cors.methods) > 0 {
info.WriteString(fmt.Sprintf(" CORS methods:\t%s\n",
strings.Join(c.config.cors.methods, ", ")))
fmt.Fprintf(&info, " CORS methods:\t%s\n",
strings.Join(c.config.cors.methods, ", "))
}

if c.config.cors.credentials {
info.WriteString(" CORS credentials:\ttrue\n")
}

if c.config.cors.maxAge != "" {
info.WriteString(fmt.Sprintf(" CORS max age:\t%s\n", c.config.cors.maxAge))
fmt.Fprintf(&info, " CORS max age:\t%s\n", c.config.cors.maxAge)
}
}

// Timeout configuration.
if v := c.config.timeout.apiShutdown; v != "" && v != daemon.DefaultAPIShutdownTimeout().String() {
info.WriteString(fmt.Sprintf(" API shutdown timeout:\t%s\n", v))
fmt.Fprintf(&info, " API shutdown timeout:\t%s\n", v)
}
if v := c.config.timeout.mcpInit; v != "" && v != daemon.DefaultClientInitTimeout().String() {
info.WriteString(fmt.Sprintf(" MCP init timeout:\t%s\n", v))
fmt.Fprintf(&info, " MCP init timeout:\t%s\n", v)
}

if v := c.config.timeout.healthCheck; v != "" && v != daemon.DefaultHealthCheckTimeout().String() {
info.WriteString(fmt.Sprintf(" MCP health check timeout:\t%s\n", v))
fmt.Fprintf(&info, " MCP health check timeout:\t%s\n", v)
}

if v := c.config.interval.healthCheck; v != "" && v != daemon.DefaultHealthCheckInterval().String() {
info.WriteString(fmt.Sprintf(" MCP health check interval:\t%s\n", v))
fmt.Fprintf(&info, " MCP health check interval:\t%s\n", v)
}

return info.String()
Expand Down
5 changes: 4 additions & 1 deletion internal/config/daemon_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,10 @@ func (a *APIConfigSection) Validate() error {
if *a.Addr == "" {
validationErrors = append(validationErrors, fmt.Errorf("API address cannot be empty"))
} else if !isValidAddr(*a.Addr) {
validationErrors = append(validationErrors, fmt.Errorf("API address \"%s\" appears to be invalid (expected format: host:port)", *a.Addr))
validationErrors = append(
validationErrors,
fmt.Errorf("API address \"%s\" appears to be invalid (expected format: host:port)", *a.Addr),
)
}
}

Expand Down
2 changes: 1 addition & 1 deletion internal/printer/server_printer.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func (p *ServerPrinter) printRuntimes(w io.Writer, pkg packages.Server) {
var b strings.Builder
b.WriteString(string(inst.Runtime))
if inst.Version != "" {
b.WriteString(fmt.Sprintf(" (version: %s)", inst.Version))
fmt.Fprintf(&b, " (version: %s)", inst.Version)
}

// Pad to align with other sections
Expand Down