Skip to content

Conversation

@dklawren
Copy link
Collaborator

@dklawren dklawren commented Oct 16, 2025

This has been successfully tested now on phabricator-dev and is ready for review.

  • If revisions have both #intermittent-reviewers and #taskgraph-reviewers as blocking then move any other blocking groups to the subscriber list.

… the reviewer is #intermittent-reviewers, do not add group reviewers as blocking
@dklawren dklawren requested a review from Copilot October 16, 2025 20:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a bug fix to handle reviewer assignment when patches contain .toml file changes and the reviewer is #intermittent-reviewers. The change prevents group reviewers from being added as blocking reviewers, instead moving them to subscribers.

  • Adds a new function set_intermittent_reviewers to handle the special case logic
  • Integrates the new function into the revision processing workflow
  • Exports the new function for use across the codebase

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
extensions/PhabBugz/lib/Util.pm Implements the core logic for handling intermittent reviewers and exports the new function
extensions/PhabBugz/lib/Feed.pm Integrates the intermittent reviewers handling into the revision change processing flow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with a few questions and a nit.

@dklawren dklawren merged commit 5d00da6 into mozilla-bteam:master Oct 21, 2025
8 checks passed
@dklawren dklawren deleted the 1981211 branch October 21, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants