Skip to content

Bug 2023624 - Some older repos have comments that have empty comment body and user object is null. The ETL script needs to handle these better instead of crashing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dklawren wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bug 2023624 - Some older repos have comments that have empty comment body and user object is null. The ETL script needs to handle these better instead of crashing #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de1476
Bug 2023624 - Some older repos have comments that have empty comment …
dklawren Mar 16, 2026
93e2486
Black formatted
dklawren Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,13 @@ def extract_reviewers(

reviewers = github_get(session, reviewers_url).json()

logger.info(f"Extracted {len(reviewers)} reviewers for PR #{pr_number}")
return reviewers
filtered = [r for r in reviewers if r.get("user") is not None]
Copy link
Member

@shtrom shtrom Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Unless you expect r["user"] to be validly False or "", you can just

Suggested change
filtered = [r for r in reviewers if r.get("user") is not None]
filtered = [r for r in reviewers if r.get("user")]

skipped = len(reviewers) - len(filtered)
if skipped:
logger.info(f"Skipped {skipped} reviewer(s) with null user for PR #{pr_number}")

logger.info(f"Extracted {len(filtered)} reviewers for PR #{pr_number}")
return filtered


def extract_comments(
Expand All @@ -329,8 +334,16 @@ def extract_comments(
logger.info(f"Comments URL: {comments_url}")

comments = github_get(session, comments_url).json()
logger.info(f"Extracted {len(comments)} comments for PR #{pr_number}")
return comments

filtered = [c for c in comments if c.get("user") is not None and c.get("body")]
Copy link
Member

@shtrom shtrom Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Suggested change
filtered = [c for c in comments if c.get("user") is not None and c.get("body")]
filtered = [c for c in comments if c.get("user") and c.get("body")]

skipped = len(comments) - len(filtered)
if skipped:
logger.info(
f"Skipped {skipped} comment(s) with null user or empty body for PR #{pr_number}"
)

logger.info(f"Extracted {len(filtered)} comments for PR #{pr_number}")
return filtered


def sleep_for_rate_limit(resp: requests.Response) -> None:
Expand Down Expand Up @@ -459,7 +472,7 @@ def transform_data(raw_data: list[dict], repo: str) -> dict:
"target_repository": repo,
"date_reviewed": review.get("submitted_at"),
"reviewer_email": None, # TODO Placeholder for reviewer email extraction logic
"reviewer_username": review.get("user", {}).get("login", "None"),
"reviewer_username": (review.get("user") or {}).get("login"),
Copy link
Member

@shtrom shtrom Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem with the error message we saw is not that user was empty, but that review was None, so that the initial Review.get... was a None.get..., which failed.

"status": review.get("state"),
}
transformed_data["reviewers"].append(transformed_reviewer)
Expand Down
Loading