landing_checks: add PreventDotGithubCheck (bug 1993136)#744
Closed
landing_checks: add PreventDotGithubCheck (bug 1993136)#744
Conversation
|
View this pull request in Lando to land it once approved. |
Member
Author
|
This is a rebased version of #701. |
shtrom
force-pushed
the
bug1993136/blocker-github-workflows-rebased
branch
from
4be2485 to
d6bb679
Compare
cgsheeh
approved these changes
Dec 5, 2025
This new Landing check allows us to prevent silent changes to the `.github/workflows` directory. It can be overridden by putting `DOT_GITHUB_OVERRIDE` in the commit message.
shtrom
force-pushed
the
bug1993136/blocker-github-workflows-rebased
branch
from
d6bb679 to
1766978
Compare
Member
Author
|
I had to squash a migration rename, and rebase onto the current main. |
Co-authored-by: Connor Sheehan <cosheehan@mozilla.com>
Co-authored-by: Zeid <2043828+zzzeid@users.noreply.github.com>
Co-authored-by: Zeid <2043828+zzzeid@users.noreply.github.com>
shtrom
force-pushed
the
bug1993136/blocker-github-workflows-rebased
branch
from
1766978 to
a816dbf
Compare
cgsheeh
approved these changes
Dec 5, 2025
|
Pull request closed by commit d924299 |
lando-prod-mozilla bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
This new Landing check allows us to prevent silent changes to the .github/workflows directory. It can be overridden by putting DOT_GITHUB_OVERRIDE in the commit message. As part of this work, mixin PreventPathCheckMixin is exctracted from PreventNSPRNSSCheck. The latter is rewritten as a façade to two new, separate, checks, PreventNSPRCheck and PreventNSSCheck, built using the new mixin. closes: #701 Pull request: #744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new Landing check allows us to prevent silent changes to the
.github/workflows directory. It can be overridden by putting
DOT_GITHUB_OVERRIDE in the commit message.
As part of this work, mixin PreventPathCheckMixin is exctracted from
PreventNSPRNSSCheck. The latter is rewritten as a façade to two new, separate,
checks, PreventNSPRCheck and PreventNSSCheck, built using the new mixin.
closes: #701