-
Notifications
You must be signed in to change notification settings - Fork 11
logging: update MozLogFormatter to output MozLog (bug 1977738) #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
330be40
495c56a
42a9403
cb13478
156756f
acaa9ef
06cff9b
24931e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,11 @@ | |
| "BACKEND": "storages.backends.gcloud.GoogleCloudStorage", | ||
| }, | ||
| } | ||
| STATIC_URL = os.getenv("STATIC_URL") | ||
|
|
||
| # If missing, we default to `STATIC_URL`, from the `from settings import *`. | ||
| # This allows the code to run in a local environment configured to simulate a remote | ||
| # environment. | ||
| STATIC_URL = os.getenv("STATIC_URL", STATIC_URL) # noqa: F405 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not clear why we are doing this here. All remote environments should set their own value here, vs. using what's in
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added this comment to the code:
Alternatively, we could add a commented-out definition of
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: I think this could be better handled, given that we may handle this stuff with a make command or other type of script. I.e., we could set this value explicitly in the environment when in "simulate remote environment" mode without needing to have a special case for this value here. |
||
| GS_BUCKET_NAME = os.getenv("GS_BUCKET_NAME") | ||
| GS_PROJECT_ID = os.getenv("GS_PROJECT_ID") | ||
| GS_QUERYSTRING_AUTH = False | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.