Closed
Conversation
|
View this pull request in Lando to land it once approved. |
shtrom
force-pushed
the
bug1979247/try/patches-SCMType
branch
2 times, most recently
from
f9df6a3 to
d9ed18b
Compare
shtrom
force-pushed
the
bug1979247/try/patches-SCMType
branch
from
d9ed18b to
a790407
Compare
cgsheeh
requested changes
Feb 24, 2026
Member
cgsheeh
left a comment
cgsheeh
left a comment
There was a problem hiding this comment.
LGTM, but this needs a bug before it can land. "No bug" is only acceptable for things like test infra updates or doc changes, anything which touches production code should have a bug in case we need to link it to regressions, use it in incident docs, etc.
shtrom
changed the title
|
Pull request closed by commit 9d7f841 |
lando-prod-mozilla bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
This is a clean split of the SCMType work from Bug 1979247, to land separately. Pull request: #945
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clean split of the SCMType work from Bug 1979247, to land separately.