landing_job: do not pickup handover jobs in all workers (bug 2019420)#949
Open
landing_job: do not pickup handover jobs in all workers (bug 2019420)#949
Conversation
|
View this pull request in Lando to land it once approved. |
zzzeid
force-pushed
the
zeid/bug-2019420-handover-job-fix
branch
2 times, most recently
from
5adb76f to
1bed162
Compare
shtrom
approved these changes
Feb 27, 2026
src/lando/api/tests/test_landings.py
Outdated
Comment on lines
+1459
to
+1461
| if "git" not in closed_repos: | ||
| assert next_git_job is None | ||
|
|
Member
There was a problem hiding this comment.
nit: Should this one be
Suggested change
| if "git" not in closed_repos: | |
| assert next_git_job is None | |
| if "git" in closed_repos: | |
| assert next_git_job is None |
?
That said, we'd get None nonetheless because there aren't any other queued jobs, so I suspect this assertion is not needed, or should at least be unconditional.
Contributor
Author
There was a problem hiding this comment.
Nice catch. This actually points to a slightly larger issue. Will push a fix.
zzzeid
force-pushed
the
zeid/bug-2019420-handover-job-fix
branch
3 times, most recently
from
894f7b6 to
722e616
Compare
zzzeid
force-pushed
the
zeid/bug-2019420-handover-job-fix
branch
from
722e616 to
4528dd3
Compare
zzzeid
commented
Mar 4, 2026
| many seconds ago. | ||
| """ | ||
| q = super().job_queue_query() | ||
| q = super().job_queue_query(repositories) |
Contributor
Author
There was a problem hiding this comment.
This is basically reverted back to the state before #748.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.