Stack.js: remove has-text-white when not needed (bug 2015588)#953
Closed
Stack.js: remove has-text-white when not needed (bug 2015588)#953
Conversation
|
View this pull request in Lando to land it once approved. |
cgsheeh
approved these changes
Feb 26, 2026
Member
cgsheeh
left a comment
cgsheeh
left a comment
There was a problem hiding this comment.
LGTM, assuming we don't need to re-add has-text-white in some other case as this should be a "final" state on the page.
Contributor
Author
Yeah at this stage, this call only happens once after page load. |
|
Pull request closed by commit 688d28c |
lando-prod-mozilla bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
Otherwise, the text is not visible as the button is also white. Pull request: #953
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the text is not visible as the button is also white.