Bug 2002301 - [phab-etl] Track all non-bmo related project members in the review_groups table and not just *-reviewers#9
Conversation
… the review_groups table and not just *-reviewers
There was a problem hiding this comment.
Pull request overview
This PR updates the phab-etl tool to track all non-BMO related project members in the review_groups table, rather than limiting tracking to only projects ending with "-reviewers". This change broadens the scope of project membership tracking.
Key Changes:
- Modified filter logic from
endswith("-reviewers")to exclude projects starting with "bmo-" prefix - Updated inline comment to reflect the new filtering criteria
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
cgsheeh
approved these changes
Nov 25, 2025
Member
cgsheeh
left a comment
cgsheeh
left a comment
There was a problem hiding this comment.
LGTM! We should test this manually to check it returns the groups we expect. :)
Contributor
Author
Thanks. Will give it a try tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.