Skip to content

Commit 4aff5da

Browse files
Bug 2019073 - Restrict AI reviews for private revisions (#75)
1 parent db0a923 commit 4aff5da

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

moz-extensions/src/reviewhelper/config/PhabricatorReviewHelperConfigOptions.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@ public function getOptions() {
4444
30
4545
)
4646
->setDescription(pht('Request timeout in seconds for the AI review service.')),
47+
$this->newOption(
48+
'reviewhelper.allow-private-revisions',
49+
'bool',
50+
false
51+
)
52+
->setDescription(pht('Allow AI review requests for private (secure) revisions. ' .
53+
'When disabled, the "Request AI Review" button and AI feedback controls are hidden on private revisions.')),
4754
$this->newOption(
4855
'reviewhelper.bot-username',
4956
'string',

moz-extensions/src/reviewhelper/events/ReviewHelperEventListener.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,18 @@ private function handleActionEvent($event) {
4040
return;
4141
}
4242

43+
$allow_private = PhabricatorEnv::getEnvConfig('reviewhelper.allow-private-revisions');
44+
if (!$allow_private) {
45+
$view_policy = $object->getViewPolicy();
46+
$is_private = !in_array($view_policy, array(
47+
PhabricatorPolicies::POLICY_PUBLIC,
48+
PhabricatorPolicies::POLICY_USER,
49+
));
50+
if ($is_private) {
51+
return;
52+
}
53+
}
54+
4355
$status = $object->getStatusObject();
4456
$is_open = !$status->isClosedStatus();
4557

0 commit comments

Comments
 (0)