Bug 2018745 - Set cancel button label to 'Okay' (#74)

suhaibmujahid · web-flow · commit db0a923cb777 · 2026-02-23T16:09:25.000-05:00
diff --git a/moz-extensions/src/reviewhelper/controller/ReviewHelperRequestController.php b/moz-extensions/src/reviewhelper/controller/ReviewHelperRequestController.php
@@ -53,13 +53,13 @@ public function handleRequest(AphrontRequest $request) {
       return $this->newDialog()
         ->setTitle(pht('Review Helper'))
         ->setErrors(array($ex->getMessage()))
-        ->addCancelButton($revision_uri);
+        ->addCancelButton($revision_uri, pht('Okay'));
     }
 
     return $this->newDialog()
       ->setTitle(pht('Review Helper'))
       ->appendParagraph($data['message'])
-      ->addCancelButton($revision_uri);
+      ->addCancelButton($revision_uri, pht('Okay'));
   }
 
   private function requestReview(

Original file line number	Diff line number	Diff line change
`@@ -53,13 +53,13 @@ public function handleRequest(AphrontRequest $request) {`
`53`	`53`	`return $this->newDialog()`
`54`	`54`	`->setTitle(pht('Review Helper'))`
`55`	`55`	`->setErrors(array($ex->getMessage()))`
`56`		`- ->addCancelButton($revision_uri);`
	`56`	`+ ->addCancelButton($revision_uri, pht('Okay'));`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`return $this->newDialog()`
`60`	`60`	`->setTitle(pht('Review Helper'))`
`61`	`61`	`->appendParagraph($data['message'])`
`62`		`- ->addCancelButton($revision_uri);`
	`62`	`+ ->addCancelButton($revision_uri, pht('Okay'));`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`private function requestReview(`