Skip to content

Commit 7824479

Browse files
committed
Bug 2015969 - Unauthenticated CircleCI webhook allows remote attackers to spoof Harbormaster build target results (PASS/FAIL)
1 parent dda84ac commit 7824479

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@ public function getHelpDocumentationArticles(PhabricatorUser $viewer) {
5252
}
5353

5454
public function getRoutes() {
55+
/* Bug 2015969 */
56+
/* 'hook/' => array( */
57+
/* 'circleci/' => 'HarbormasterCircleCIHookController', */
58+
/* 'buildkite/' => 'HarbormasterBuildkiteHookController', */
59+
/* ), */
5560
return array(
5661
'/B(?P<id>[1-9]\d*)' => 'HarbormasterBuildableViewController',
5762
'/harbormaster/' => array(
@@ -95,7 +100,6 @@ public function getRoutes() {
95100
'(?P<id>\d+)/' => 'HarbormasterLintMessagesController',
96101
),
97102
'hook/' => array(
98-
'circleci/' => 'HarbormasterCircleCIHookController',
99103
'buildkite/' => 'HarbormasterBuildkiteHookController',
100104
),
101105
'log/' => array(

0 commit comments

Comments
 (0)