Skip to content

Update make test to deal with schema change#907

Merged
bheesham merged 8 commits intomozilla-iam:masterfrom
bheesham:ugh
Apr 24, 2025
Merged

Update make test to deal with schema change#907
bheesham merged 8 commits intomozilla-iam:masterfrom
bheesham:ugh

Conversation

@bheesham
Copy link
Copy Markdown
Contributor

Jira: IAM-950

  • All PRs are assigned to the review team automatically.
  • New integrations: Legal and Security reviews confirmed. authorized_groups and Auth0 client_id are defined. If display: true, the logo's image is attached. Auth0 app's Connections enables LDAP only.

@bheesham
Copy link
Copy Markdown
Contributor Author

@gcoxmoz brought up a good point re: the schemas here -- logo and url are both set for regular apps. I've added them back here, though I believe they're optional.

We should probably have a larger discussion about schema validation, at some point, since there are now multiple consumers of this file.

We will be using apps.yml for access checks as a part of the login flow, for
denying access to unlisted apps.

As a result, the name of this repository is a bit of a misnomer, but so it
goes.

Jira: IAM-950
See commit 58a4706e01e6e2504a1c9f7f888986dd422bf6ec of sso-dashboard.

Jira: IAM-950
Copy link
Copy Markdown
Contributor

@gcoxmoz gcoxmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unstick/breakfix. This should help in codifying a schema near to what we already have, and someone can handsmack me if I'm overstepping here.

@bheesham
Copy link
Copy Markdown
Contributor Author

Forward the handsmacking to me, if anything -- I broke it. 🙃

🎩 thanks for the approval.

@bheesham bheesham merged commit 0b51e6a into mozilla-iam:master Apr 24, 2025
1 check passed
@bheesham bheesham deleted the ugh branch April 24, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants