Skip to content

Logo refresh#912

Closed
bheesham wants to merge 1 commit intomozilla-iam:masterfrom
bheesham:logo-refresh
Closed

Logo refresh#912
bheesham wants to merge 1 commit intomozilla-iam:masterfrom
bheesham:logo-refresh

Conversation

@bheesham
Copy link
Copy Markdown
Contributor

@bheesham bheesham commented Apr 30, 2025

  • All PRs are assigned to the review team automatically.
  • New integrations: Legal and Security reviews confirmed. authorized_groups and Auth0 client_id are defined. If display: true, the logo's image is attached. Auth0 app's Connections enables LDAP only.

Jira: IAM-1609

@bheesham bheesham requested a review from a team as a code owner April 30, 2025 17:21
@bheesham
Copy link
Copy Markdown
Contributor Author

bheesham commented Apr 30, 2025 

Ran 2 tests in 0.507s

OK

@bheesham bheesham mentioned this pull request Apr 30, 2025
Closed
@bheesham
Visual consistency among logos
72f7c00 
Generally replaces tiles with ones which have logos, and adding a text mark to
Mozilla-ran services.

Jira: IAM-1609
@bheesham bheesham changed the title Logo refresh and addressing lint Logo refresh May 1, 2025
@dividehex
Copy link
Copy Markdown
Contributor

dividehex commented May 2, 2025

@bheesham What is the reasoning behind converting all the images from png to jpg?

@bheesham
Copy link
Copy Markdown
Contributor Author

bheesham commented May 2, 2025

@bheesham What is the reasoning behind converting all the images from png to jpg?

Reached out to Mary for justification.

@moregan-moz
Copy link
Copy Markdown

moregan-moz commented May 2, 2025

@dividehex @bheesham We are happy to deliver the images in whatever file type you think is best. Let us know. Thanks!

@bheesham
Copy link
Copy Markdown
Contributor Author

bheesham commented May 5, 2025

png's are probably best.

@dividehex, were you worried about image transparency?

@janbrasna
Copy link
Copy Markdown
Contributor

janbrasna commented Jun 21, 2025 •
edited
Loading

png's are probably best.
were you worried about image transparency?

JPEG compression for this type of illustrations does not work well. Demonstrated by some of the logo size inflated 10x+ in the PR. (Also the change to all the file names is unnecessarily noisy.)

If possible to have these in PNG in the right size (130px in retina i.e. 260px) and also run some pngcrush or imageoptim on them would greatly help the overall filesize.

@bheesham FYI I'm liaising with brand to have the most appropriate formats and will update here once I have something.

@janbrasna janbrasna mentioned this pull request Jul 24, 2025
Merged
2 tasks
@bheesham bheesham closed this Jul 25, 2025
@bheesham bheesham deleted the logo-refresh branch July 25, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bheesham @dividehex @moregan-moz @janbrasna