Skip to content

Remove New Relic tiles except Primary one#916

Merged
bheesham merged 1 commit intomozilla-iam:masterfrom
willkg:patch-2
May 7, 2025
Merged

Remove New Relic tiles except Primary one#916
bheesham merged 1 commit intomozilla-iam:masterfrom
willkg:patch-2

Conversation

@willkg
Copy link
Copy Markdown
Contributor

@willkg willkg commented May 1, 2025

This removes all the New Relic tiles except the primary one.

See https://mozilla-hub.atlassian.net/browse/MZCLD-174

  • All PRs are assigned to the review team automatically.
  • New integrations: Legal and Security reviews confirmed. authorized_groups and Auth0 client_id are defined. If display: true, the logo's image is attached. Auth0 app's Connections enables LDAP only.

This removes all the New Relic tiles except the primary one.

See https://mozilla-hub.atlassian.net/browse/MZCLD-174
@willkg willkg requested a review from a team as a code owner May 1, 2025 23:12
@bheesham
Copy link
Copy Markdown
Contributor

bheesham commented May 5, 2025

Hey @willkg, thanks for the contribution!

There's been a couple of changes recently in how this file is used, primarily: we use it as a gate for access controls in Auth0 now. Before, we used to allow an authenticated user access to an undefined app (read as: missing from this configuration). This is no longer the case.

(The name of this repo is now a bit misleading, apologies.)

The accepted ways to remove apps from the SSO Dashboard would be to either:

  • fully decommission the application (deleting the app in Auth0, removing it from this file);
  • set the display: false property of the apps in this file.

@willkg
Copy link
Copy Markdown
Contributor Author

willkg commented May 5, 2025

Mozilla has used the New Relic vendor for a really long time, but we've changed how we use New Relic and how authentication works. Originally, authentication was by New Relic organization. At some point, that changed and now authentication for all New Relic organizations is handled by a single New Relic Corporate Primary organization. That also has an app in the apps.yaml file--I didn't touch that one.

This PR removes all the apps for New Relic which correspond to organizations which no longer exist as well as apps for which we no longer use for authentication leaving the Primary app intact with display: false:

- application:
AAL: LOW
authorized_groups:
- everyone
authorized_users: []
display: false
op: auth0
client_id: Eisz30vfCy8w9ie06e9HdEgO6DICmhHA
name: New Relic - Primary (139239)
url: https://sso.mozilla.com/
logo: auth0.png

Does that make sense? Are you still advising we keep the tiles instead and set them to display: false?

@bheesham
Copy link
Copy Markdown
Contributor

bheesham commented May 6, 2025

Ah, if that's the case then we should delete these apps out of Auth0, fully decommissioning them.

I can delete the ones listed here from Auth0, if you're alright with that.

@willkg
Copy link
Copy Markdown
Contributor Author

willkg commented May 6, 2025

Can I get a list of what you're deleting specifically?

@bheesham
Copy link
Copy Markdown
Contributor

bheesham commented May 6, 2025

The applications which you're removing here:

App Client Id
New Relic IT SRE tAtVU4uyJhaXdMEglSWKxMHliBm9yYtS
New Relic EIS yrtYw37UYq5gkna3j9f0P4L0oQD8Y6aQ
New Relic Emerging Tech Um2rLocE3s851JXNZzTPnA5DFzWe9OhQ
New Relic SubHub VeOfYrHRjGuAauFAXRYv4z0rCFe4Ibbc
New Relic - Mozilla 25 (1402187) kXG2TTVKHERiM0FbB25TGCNPNxDFaVSB
New Relic - Web Predictability (1872822) yRI1HQiw0eAiGtLvuh2y706rP5NYpdLk

@willkg
Copy link
Copy Markdown
Contributor Author

willkg commented May 7, 2025

That list looks good. Thank you! 👍

Copy link
Copy Markdown
Contributor

@bheesham bheesham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apps have been deleted out of Auth0. You're good to merge!

@bheesham bheesham merged commit 28cf76b into mozilla-iam:master May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants