Skip to content

fix(docker-build): Fix a few more issues in the docker build workflow #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grahamalama merged 2 commits into from
Jun 16, 2025
Merged

fix(docker-build): Fix a few more issues in the docker build workflow #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb5038f
fix(docker-build): Use correct syntax for multiline output for images…
grahamalama Jun 16, 2025
2ceef2b
fix(docker-build): test for presence of correct metadata env var
grahamalama Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions docker-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ runs:
tag="$(git rev-parse --short=10 HEAD)"
fi
# append metadata if present
if [[ -n "$metadata" ]]; then
if [[ -n "${IMAGE_TAG_METADATA}" ]]; then
tag="${tag}--${IMAGE_TAG_METADATA}"
fi
echo "Setting IMAGE_TAG=${tag} as output"
Expand All @@ -69,12 +69,20 @@ runs:
IMAGE_NAME: ${{ inputs.image_name }}
SHOULD_TAG_GHCR: ${{ inputs.should_tag_ghcr }}
run: |
images="${GAR_LOCATION}-docker.pkg.dev/${PROJECT_ID}/${GAR_NAME}/${IMAGE_NAME}"
images=( "${GAR_LOCATION}-docker.pkg.dev/${PROJECT_ID}/${GAR_NAME}/${IMAGE_NAME}" )
if [[ "${SHOULD_TAG_GHCR}" == "true" ]]; then
images="${images}"$'\n'"ghcr.io/${{ github.repository }}/${IMAGE_NAME}"
images+=( "ghcr.io/${{ github.repository }}/${IMAGE_NAME}" )
fi
echo -e "Generated Images:\n${images}"
echo -e "IMAGES=<<EOF\n${images}\nEOF" >> "$GITHUB_OUTPUT"

# Debug output
echo "Generated Images:"
printf '%s\n' "${images[@]}"

{
echo "images<<EOF"
printf '%s\n' "${images[@]}"
echo "EOF"
} >> "$GITHUB_OUTPUT"

- name: Set tag list
shell: bash
Expand All @@ -83,13 +91,21 @@ runs:
SHOULD_TAG_LATEST: ${{ inputs.should_tag_latest }}
IMAGE_TAG: ${{ steps.mozcloud-tag.outputs.image_tag }}
run: |
tags="type=raw,value=${IMAGE_TAG}"
tags=( "type=raw,value=${IMAGE_TAG}" )
if [[ "${SHOULD_TAG_LATEST}" == "true" ]]; then
tags="${tags}"$'\n'"type=raw,value=latest"
tags+=( "type=raw,value=latest" )
fi
echo -e "Generated Tags:\n${tags}"
echo -e "TAGS=<<EOF\n${tags}\nEOF" >> "$GITHUB_OUTPUT"


# Debug output
echo "Generated Tags:"
printf '%s\n' "${tags[@]}"

{
echo "tags<<EOF"
printf '%s\n' "${tags[@]}"
echo "EOF"
} >> "$GITHUB_OUTPUT"

- name: Docker meta
id: meta
uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804 #v5.7.0
Expand Down