BugFix FXIOS-28385 [Search Suggestions] Keep suggestions visible when scrolling on Custom New Tab

[ananyashreesharma]

🧾 Tickets

• GitHub issue

📝 Description

When New Tab is set to Custom, dragging the suggestions list hides the keyboard and unintentionally cancels URL bar editing, which closes the suggestions abruptly
This change skips the keyboard hide auto cancel while suggestions are visible aligning behaviour with Firefox Home/Blank.

Before

issue.mp4

After

fix.mp4

Test plan

• Setup:
  • Settings → General → New Tab → Custom, URL: https://www.google.com
  • Address bar position: verify both Top and Bottom
• Custom New Tab
  • Type “fir”; drag/bounce suggestions → suggestions stays
  • Tap Cancel while dragging → overlay closes.
  • Tap a suggestion → loads and overlay closes.
  • Press Return → submits and closes.
  • Rotate mid-scroll; start/stop dictation → no unintended dismiss.
• Firefox Home & Blank: drag keeps suggestions; Cancel still dismisses.
• Private: unchanged (no suggestions until turned on manually)

✅ Checklist

• I filled in the ticket numbers and a description of my work

• I updated the PR name to follow our PR naming guidelines

• I ensured unit tests pass and wrote tests for new code

• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)

• If adding telemetry, I read the data stewardship requirements and will request a data review

• If adding or modifying strings, I read the guidelines and will request a string review from l10n

• If needed, I updated documentation and added comments to complex code

• Fixes Suggestions view closes when attempting to scroll, when New Tab is set to Custom #28385

[github-actions]

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

[FilippoZazzeroni]

Hi @ananyashreesharma sorry for the super late review and thanks very much for opening this PR. I think the issue here is that when the new tab choice is the custom one then the searchTerm is always nil. So the issue actually it's not in this piece of code but could be directly in how we handle state on the Toolbar. cc @thatswinnie