Skip to content

Conversation

@mattreaganmozilla
Copy link
Collaborator

@mattreaganmozilla mattreaganmozilla commented Dec 12, 2025

📜 Tickets

Jira ticket

💡 Description

There is an ongoing discussion as to how the scopes and OAuth should be handled for Relay. Currently it's unclear as to whether we should actually request the Relay scope during sign-in. This PR removes the scopes for now until we can get additional clarity around the correct approach.

Without these scopes, Relay will not work at all in iOS, since the API to get the token will fail. However, even with them in place, we have problems (such as users who are already signed in -- for them, Relay still will not work unless they log out and back in).

Related discussions:

https://mozilla.slack.com/archives/C0559DDDPQF/p1765397553206879
https://mozilla.slack.com/archives/C09A0SMGUVA/p1765409381617839

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mattreaganmozilla
Copy link
Collaborator Author

@mhammond @issammani I'm still not entirely clear on whether we should include the Relay scope for now. Wanted to put this PR up so we could remove if that's the correct approach moving forward.

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Dec 12, 2025

Messages
📖 Project coverage: 38.47%

🧹 Tidy commit

Just 3 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.23

File Coverage
FirefoxAccountSignInViewController.swift 35.62% ⚠️
FxAWebViewModel.swift 14.02% ⚠️

libAccount.a: Coverage: 54.09

File Coverage
RustFirefoxAccounts.swift 56.39%

Generated by 🚫 Danger Swift against 26a38ac

@mattreaganmozilla
Copy link
Collaborator Author

@mhammond @issammani I haven't been able to get a clear answer on this yet, but I believe our current plan based on the discussions in Relay channel is that we'll be keeping these scopes in place, so I'm going to close this PR.

@mhammond
Copy link
Contributor

sorry for the delay. As you note above, this will leave relay broken for users already signed in. For users who sign in the future, I believe they will find in their "manage account" page that they have connected the "relay" service to their account, even though there is a good chance they've never heard of it.

I personally think it should be removed as it might cause users to lose trust in us and relay in particular, but really this is a product question rather than an engineering one.

@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2026

This pull request has conflicts when rebasing. Could you fix it @mattreaganmozilla? 🙏

@mattreaganmozilla
Copy link
Collaborator Author

@issammani (+cc @mhammond) I've reopened this since, per the sync today, it sounds like we do not want to include Relay scopes for sign-in for the time being. LMK if any questions/concerns.

Copy link
Contributor

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mattreaganmozilla
Copy link
Collaborator Author

@ih-codes @lmarceau This change has been discussed thoroughly with Relay team but I need an iOS approval to merge, can anyone give this a quick review? Thank you

@mattreaganmozilla mattreaganmozilla changed the title Remove FXIOS-14400 [Relay] [TBD] Remove Relay OAuth scopes Remove FXIOS-14400 [Relay] Remove Relay OAuth scopes Jan 15, 2026
@mattreaganmozilla mattreaganmozilla merged commit 1ab90ba into mozilla-mobile:main Jan 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants