-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Remove FXIOS-14400 [Relay] Remove Relay OAuth scopes #31267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FXIOS-14400 [Relay] Remove Relay OAuth scopes #31267
Conversation
|
@mhammond @issammani I'm still not entirely clear on whether we should include the Relay scope for now. Wanted to put this PR up so we could remove if that's the correct approach moving forward. |
🧹 Tidy commitJust 3 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ✅ Per-file coverageAll changed files meet the threshold of 35.0%. Client.app: Coverage: 37.23
libAccount.a: Coverage: 54.09
Generated by 🚫 Danger Swift against 26a38ac |
|
@mhammond @issammani I haven't been able to get a clear answer on this yet, but I believe our current plan based on the discussions in Relay channel is that we'll be keeping these scopes in place, so I'm going to close this PR. |
|
sorry for the delay. As you note above, this will leave relay broken for users already signed in. For users who sign in the future, I believe they will find in their "manage account" page that they have connected the "relay" service to their account, even though there is a good chance they've never heard of it. I personally think it should be removed as it might cause users to lose trust in us and relay in particular, but really this is a product question rather than an engineering one. |
|
This pull request has conflicts when rebasing. Could you fix it @mattreaganmozilla? 🙏 |
ac30ddf to
efe2edc
Compare
|
@issammani (+cc @mhammond) I've reopened this since, per the sync today, it sounds like we do not want to include Relay scopes for sign-in for the time being. LMK if any questions/concerns. |
mhammond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
📜 Tickets
Jira ticket
💡 Description
There is an ongoing discussion as to how the scopes and OAuth should be handled for Relay. Currently it's unclear as to whether we should actually request the Relay scope during sign-in. This PR removes the scopes for now until we can get additional clarity around the correct approach.
Without these scopes, Relay will not work at all in iOS, since the API to get the token will fail. However, even with them in place, we have problems (such as users who are already signed in -- for them, Relay still will not work unless they log out and back in).
Related discussions:
https://mozilla.slack.com/archives/C0559DDDPQF/p1765397553206879
https://mozilla.slack.com/archives/C09A0SMGUVA/p1765409381617839
📝 Checklist