Fix #29705 - Show error alert for no internet in SUMO page

[MarkKirichko2002]

📜 Tickets

Jira ticket
Github issue

💡 Description

• Changed no-network behavior for SUMO articles (opened from onboarding cards) to load the standard offline error page from PrivacyPolicyViewController, instead of UIAlertController or blank page.
• Follows existing project precedent for localized no-connectivity error handling.
• Removed UIAlertController per reviewer feedback and consistency.
• Reverted unrelated/local files: project.pbxproj, version.xcconfig, package-lock.json.
• Ran swiftlint --config ../.swiftlint.yml --fix locally — all trailing whitespace and warnings resolved.

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

Notes:

• Reproduction: Simulator only — load SUMO article → disable network → reopen → previously blank page (or alert in initial PR), now shows localized offline error page.
• Not reproducible on physical device (native error handling kicks in, as per reviewer).
• Fix reuses existing error page logic — no new UI elements or alerts added.

[Foxbolts]

Hey @MarkKirichko2002 - thanks for tackling this issue 🥳

Looks like this is your first contribution to the project, so first of all, welcome!

I'd like to start by pointing you to our Contribution guidelines where you will find everything you need to know before contributing to the project, including things like our code style guidelines and pull request naming style guidelines.

It looks like you may have missed our pull request description template which we use for all pull requests.

I have investigated this issue previously and was only able to reproduce the blank page on the simulator after successfully loading the SUMO article, disabling network connectivity, and re-opening the SUMO article. I was not able to reproduce this on a physical device. Were you able to reproduce on a physical device?

As far as the actual resolution, I believe we would want to solve this a bit differently. As you can see in this line of PrivacyPolicyViewController, we have a specific error page we want to load when there is no network connectivity. We'd like to continue using this error page as opposed to a UIAlertViewController, as this is already the precedent set and it contains localized error messages.

It appears you also contributed some unnecessary files like local changes to project.pbxproj, version.xcconfig, and package-lock.json - all of these should be reverted as they do not pertain to the issue you worked on.

Finally, I recommend running swiftlint --config ../.swiftlint.yml --fix locally as there seems to be quite a few warnings pertaining to trailing whitespace

If you have any questions, please let me know!

[mergify]

This pull request has conflicts when rebasing. Could you fix it @MarkKirichko2002? 🙏

[Foxbolts]

Hey @MarkKirichko2002 thanks for pushing some new changes. I pulled down your branch and noticed a couple of issues when testing it:

1. Instead of showing our "The internet connection appears to be offline" error message, I am seeing "The operation couldn't be completed." Lets make sure we are presenting the correct error page

2. After receiving the error message, and re-enabling my network connection, I still see the error message when tapping a link, even though I have network connectivity.

Furthermore, I noticed there are still changes to the project.pbxproj and package-lock.json files that should all be reverted.

[Foxbolts]

@MarkKirichko2002 thanks for the additional changes, looks like you have some conflicts, hopefully that resolves the changes to the project files as those seem unrelated to this change.

@dicarobinho are you familiar in this area? Would mind taking a look at this solution?

[mergify]

This pull request has conflicts when rebasing. Could you fix it @MarkKirichko2002? 🙏

[mergify]

This pull request has conflicts when rebasing. Could you fix it @MarkKirichko2002? 🙏