Skip to content

Conversation

@issammani
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR:

  • Swaps UIToolbar for TestableUIToolbar in AccessoryViewProvider

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@issammani issammani requested a review from clarmso January 13, 2026 12:16
@issammani issammani requested a review from a team as a code owner January 13, 2026 12:16
@issammani
Copy link
Collaborator Author

@clarmso can you trigger a run on the failing tests to see if this fixes it. I am pretty sure it's the same issue as #29114

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jan 13, 2026

Messages
📖 Project coverage: 38.47%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.28

File Coverage
AccessoryViewProvider.swift 65.81%

Generated by 🚫 Danger Swift against 79c0a05

@clarmso clarmso requested a review from a team as a code owner January 13, 2026 16:21
@clarmso
Copy link
Collaborator

clarmso commented Jan 13, 2026

😞 I do not see the autofill on both iPhone 17 iOS 26.2 and iPhone 16 iOS 18.6.
Simulator Screenshot - iPhone 17 - 2026-01-13 at 11 47 27

Copy link
Collaborator

@clarmso clarmso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@issammani Please ensure autofill is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants