Bugfix FXIOS-14641 - [Toolbar] - Subdomain text loses themed color when tab tray button is tapped

[PARAIPAN9]

📜 Tickets

Jira ticket
Github issue

💡 Description

• For some reason, almost every time applyTheme was called in LocationView, the textColor of urlTextField was being overridden by the applyTheme method in LocationTextField.
• To resolve this, I removed the color assignment for urlTextField from LocationTextField since we already set it when formatting the URL.
• This change also allowed me to reduce the number of formatAndTruncateURLTextField() calls.

Before

before.MP4

After

after.MP4

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[mobiletest-ci-bot]

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against 20c2723

[thatswinnie]

I think the location field text color is actually needed as it handles the text color when editing the url. The PR introduced a new bug in regards to this:
https://github.com/user-attachments/assets/45ad5b31-65d0-462a-bcd6-90db8d769a74

[thatswinnie]

@PARAIPAN9 thanks for the fix. Unfortunately there is still a bug related to editing: When changing the theme when a suggestion is present the suggestion is not getting the new theme.
https://github.com/user-attachments/assets/17d130cc-5610-485d-821f-af93fe226dd2

Additionally: do we really need to call formatAndTruncateURLTextField() in configure when it is called a couple lines later again in applyTheme?

[PARAIPAN9]

@PARAIPAN9 thanks for the fix. Unfortunately there is still a bug related to editing: When changing the theme when a suggestion is present the suggestion is not getting the new theme. https://github.com/user-attachments/assets/17d130cc-5610-485d-821f-af93fe226dd2

Additionally: do we really need to call formatAndTruncateURLTextField() in configure when it is called a couple lines later again in applyTheme?

This appears to be a preexisting bug not introduced by this PR. Happy to fix it in a follow-up.