Skip to content

Refactor FXIOS-14663 [Previews] Show full URL when link preview is disabled #31700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janbrasna wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

Refactor FXIOS-14663 [Previews] Show full URL when link preview is disabled #31700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e20491
Show full URL with link preview disabled
janbrasna Jan 7, 2026
fcd3643
Fixup review feedback
janbrasna Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...end/Browser/BrowserViewController/Extensions/BrowserViewController+WebViewDelegates.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,17 @@ extension BrowserViewController: WKUIDelegate {

let isPrivate = currentTab.isPrivate

let showPreview = profile.prefs.boolForKey(PrefsKeys.ContextMenuShowLinkPreviews) ?? true
let urlTitle = !showPreview ? url.absoluteString : (url.normalizedHost ?? url.absoluteString)

let actions = createActions(isPrivate: isPrivate,
url: url,
addTab: self.addTab,
title: elements.title,
image: elements.image,
currentTab: currentTab,
webView: webView)
return UIMenu(title: url.normalizedHost ?? url.absoluteString, children: actions)
return UIMenu(title: urlTitle, children: actions)
}
}

Expand Down