Skip to content

Conversation

@yoanarios
Copy link
Contributor

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

  • Adding unit tests to existing classes with low or no test coverage, focusing on State objects, Extensions, and Model classes.

πŸ“ Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@yoanarios yoanarios requested a review from a team as a code owner January 21, 2026 16:18
@yoanarios yoanarios requested review from lmarceau and mdotb-moz and removed request for mdotb-moz January 21, 2026 16:18
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jan 21, 2026

Messages
πŸ“– Project coverage: 38.61%

πŸ’ͺ Quality guardian

2 tests files modified. You're a champion of test coverage! πŸš€

πŸ₯‡ Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
BrowserKit/Sources/Shared/Extensions/CGRectExtensions.swift 0.0% 35.0%

Client.app: Coverage: 37.41

File Coverage
ToggleButton.swift 47.52% ⚠️

Generated by 🚫 Danger Swift against dbe606c

@yoanarios yoanarios force-pushed the yrd/add-unit-test-extensions branch from 6fb641c to 2df3dd8 Compare January 22, 2026 14:33
@yoanarios yoanarios requested a review from lmarceau January 22, 2026 18:25
@yoanarios yoanarios merged commit 339b140 into main Jan 23, 2026
10 checks passed
@yoanarios yoanarios deleted the yrd/add-unit-test-extensions branch January 23, 2026 17:17
@github-actions
Copy link
Contributor

πŸš€ PR merged to main, targeting version: 147.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants