Bugfix FXIOS-14657 Add PlainToast, fix toast displays for Relay

[mattreaganmozilla]

📜 Tickets

Jira ticket
Github issue

💡 Description

Our existing SimpleToast presentation code from BVC has a few issues. This is part of a broader problem that needs to be addressed in the client. This PR takes the initial first step towards that:

• Adds a new PlainToast to replace SimpleToast
• Updates the Relay toasts to use the new PlainToast subclass
• Organizes the Toast and subclasses into a new separate project folder
• TBD: Replace our other SimpleToast usages in the BVC?
  • @lmarceau This should be a small change, unless you think there's risk involved I can push this up also

🔧 Xcode Project Changes

🎥 Demos

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 37.91%

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

• ✨ Change in file size: +6 lines

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File	Coverage	Required
firefox-ios/Client/Frontend/Browser/Toasts/PlainToast.swift	0.0%	35.0%
firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift	29.7%	35.0%

Client.app: Coverage: 37.44

File	Coverage
BrowserViewController.swift	29.73%	⚠️
PlainToast.swift	0.0%	⚠️
ButtonToast.swift	71.74%	✅
DownloadToast.swift	77.54%	✅
Toast.swift	80.0%	✅

Generated by 🚫 Danger Swift against be196b4

[lmarceau]

TBD: Replace our other SimpleToast usages in the BVC?

Yeah makes sense, I thought the changes would be more disruptive but that seems good as is! Just mention what toasts should be tested by QA on the JIRA ticket maybe? Or we can create a separate ticket just for QA to test the other toasts not related to relay 🤔 as you wish!

[mattreaganmozilla]

@lmarceau I'm going to merge this for now and revisit the other Toast updates, I have a ToDo/action item on my list to file a Jira with notes on several other improvements to the toast system, want to double-check with the team first that it won't be a duplicate

[github-actions]

🚀 PR merged to main, targeting version: 147.4