Bugfix FXIOS-13534 #29419 ⁃ Firefox widgets look weird on iOS26 glass mode #31777
+86
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧹 Tidy commitJust 4 file(s) touched. Thanks for keeping it clean and review-friendly! 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
WidgetKitExtension.appex: Coverage: 4.86
Generated by 🚫 Danger Swift against ce4f6dd |
Collaborator
|
@dicarobinho unfortunately none of the icons (Firefox or website icons) are visible. Additionally I think the |
thatswinnie
reviewed
Jan 23, 2026
| .multilineTextAlignment(.leading) | ||
| .lineLimit(1) | ||
| .font(.system(size: 15, weight: .regular, design: .default)) | ||
| .lineLimit(1).font(.system(size: 15, weight: .regular, design: .default)) |
Collaborator
There was a problem hiding this comment.
Can we undo this change? The modifiers should be on separate lines.
| ZStack(alignment: .leading) { | ||
| if !isSmall { | ||
| background | ||
| if #available(iOS 16.0, *) { |
Collaborator
There was a problem hiding this comment.
Can we keep the background and logo variables and move the availability check there? It made the code more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Applied glass effect when renderMode is accented
🎥 Demos
Demo
📝 Checklist