Bugfix FXIOS-14715 Stopgap measure to downgrade Swift 6 while we investigate a more robust solution (backport #31793) #31796
Conversation
…stigate a more robust solution (#31793) * Stopgap downgrade of Swift 6 while we resolve WKNavigationDelegate methods not being called properly. Bumping warning threshold. * Downgrade ClientTests to Swift 5 as well to avoid errors after some Swift 6 related changes were made. * Apply suggestion from @ih-codes Bump warning count. (cherry picked from commit 5878473)
Uplift Request[User impact if declined]: Several authentication methods will be broken without this fix, as well as JS alerts (bug introduced in 147.1) [Is this code covered by automated tests?] Partially, but the bug itself bypasses our CI due to the issue stemming from compiler optimizations and dead code stripping in production builds (which doesn't happen in Fennec targets) [Has the fix been verified in Nightly?] Bug verified in Nightly, fix verified by devs locally [Needs manual test from QA?] Yes [List of other uplifts needed] n/a [Why is the change risky/not risky? (and alternatives if risky)] Changes our Swift compiler version, some inherent risk but the bug this fixes has considerable user impact [String changes made/needed] n/a |
|
+cc @mozilla-mobile/relman |
|
📜 Tickets
Jira ticket
Github issue
💡 Description
Temporary stopgap measure: Downgrade Swift 6 while we investigate a more robust solution for what appears to be an issue with a WKWebNavigationDelegate method being compiled out with release build optimization for Swift 6.
Bumping the warning threshold to accommodate some Swift 6 language changes we've made in the past couple weeks after upgrading to Swift 6.
More details to come.
📝 Checklist
This is an automatic backport of pull request #31793 done by [Mergify](https://mergify.com).