(Windows) Add manifest for accurate OS version detection #10321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
basti/add_manifest
branch
from
8a0cbf2 to
5446ffb
Compare
strseb
force-pushed
the
basti/add_manifest
branch
2 times, most recently
from
f69d72f to
7fc918e
Compare
strseb
changed the title
Windows lies about the OS version to applications for compatibility unless they explicitly declare tested versions via manifest. Without maxversiontested, the app gets fake version numbers. Changes: - Add windows/vpn.manifest with maxversiontested for Windows 11 24H2 - Declare requestedExecutionLevel=asInvoker (GUI runs unprivileged) - Enable PerMonitorV2 DPI awareness for proper high-DPI support - Simplify msvc.cmake to only apply MSVC-specific flags to actual MSVC The MSVC-only flags (/ZI for edit-and-continue) don't work with clang-cl, so we now explicitly check for MSVC instead of excluding clang.
strseb
force-pushed
the
basti/add_manifest
branch
from
7fc918e to
31020ce
Compare
mcleinman
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows lies about the OS version to applications for compatibility
unless weexplicitly declare tested versions via manifest. Without
maxversiontested, we get fake version numbers.
Before:
After: