VPN-2199: Build MSI installer for arm64 #10921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
force-pushed
the
vpn-2199-arm64-msi-installer
branch
from
e242d8c to
11d1527
Compare
oskirby
force-pushed
the
vpn-2199-arm64-msi-installer
branch
from
b325803 to
0af1eb7
Compare
oskirby
force-pushed
the
vpn-2199-arm64-msi-installer
branch
from
0af1eb7 to
c4582f7
Compare
oskirby
force-pushed
the
vpn-2199-arm64-msi-installer
branch
from
2eaf655 to
34369db
Compare
oskirby
force-pushed
the
vpn-2199-arm64-msi-installer
branch
from
34369db to
441ad89
Compare
strseb
reviewed
Jan 5, 2026
| $env:PATH += ";$CMAKE_INSTALL_DIR\bin" | ||
|
|
||
| # Download ninja | ||
| Invoke-WebRequest -UseBasicParsing -Uri https://github.com/ninja-build/ninja/releases/download/v1.13.2/ninja-win.zip -OutFile $env:MOZ_FETCHES_DIR\ninja-win.zip |
Collaborator
There was a problem hiding this comment.
I think this should be a fetch request.
Or maybe we have this task pull the conda-packed env? (given that has ninja and cmake?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds taskcluster jobs to build the MSI installers for arm64.
In order to get there, we needed to update Wix, so we went with version 5.0.2 (the latest before the maintenance fee kicks in) and updates to the newer v4 schema, and we put some work into updating the CMake targets that drive the MSI build process.
And, as a bonus, we try to add support for string localization to the MSI build process.
Reference
JIRA Issue: VPN-2199
Checklist