Complete eRegenerateKey immediately #10943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #10855
There's an extra delay unrelated to the network request when regenerating keys, as noted by Valentina. It seems to happen because we wait for TaskControllerAction to time out before transitioning to the next task.
The fix is to complete eRegenerateKey task action immediately, since the actual key regeneration is handled by subsequently launched TaskAddDevice, so there's no need to wait for an async operation.
Reference
VPN-2693
Checklist