Skip to content

Conversation

@artfwo
Copy link
Collaborator

@artfwo artfwo commented Jan 5, 2026

Description

Follow-up to #10855

There's an extra delay unrelated to the network request when regenerating keys, as noted by Valentina. It seems to happen because we wait for TaskControllerAction to time out before transitioning to the next task.

The fix is to complete eRegenerateKey task action immediately, since the actual key regeneration is handled by subsequently launched TaskAddDevice, so there's no need to wait for an async operation.

Reference

VPN-2693

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@artfwo artfwo requested review from mcleinman, oskirby and strseb January 5, 2026 14:53
@artfwo artfwo marked this pull request as draft January 5, 2026 16:44
@artfwo
Copy link
Collaborator Author

artfwo commented Jan 5, 2026

One testConnection case is failing because the mock response is returned too quickly, this is now fixed in 3a38e6b

@artfwo artfwo marked this pull request as ready for review January 6, 2026 10:46
Copy link
Collaborator

@oskirby oskirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artfwo artfwo merged commit eb9c8fc into main Jan 9, 2026
154 of 157 checks passed
@artfwo artfwo deleted the vpn-2693-wireguard-key-rotation-2 branch January 9, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants