Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #11091, QA kicked this back as it still had issues for Messages and Settings. I've made a more general solution, but also have made it iOS-only. Most of the things I'm changing were done by a former engineer who had done a deep dive into Accessibility, and were needed for Android. I'm hesitant to mess with things that could affect other platforms' accessibility - hence the conservative iOS-only for most of this.
In addition to fixing the "tap to select bottom bar buttons" fixes, I've included a few other things that jumped out at me:
Reference
VPN-7459
Checklist