Restrict click to a version earlier than 8.2.0. #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 8.2.0 of click introduces incompatible changes to the CliRunner test class while at the same time increasing the minimum supported Python version to 3.10. crahsstats-tools still supports Python 3.9, so we'll use click earlier than 8.2.0 for Python 3.9 and newer versions of click for newer versions of Python. Since the changes to CliRunner are backwards-incompatible, we'd need different versions of the test code for different versions of Python. To simplify things, I'll just pin click to the old version for now, and we can properly fix this once we drop support for Python 3.9 later this year.
leplatrem
approved these changes
May 27, 2025
There was a problem hiding this comment.
For future reference, Python 3.9 supports ends in 5 months: https://endoflife.date/python (31/10/25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 8.2.0 of click introduces incompatible changes to the CliRunner test class while at the same time increasing the minimum supported Python version to 3.10. crahsstats-tools still supports Python 3.9, so we'll use click earlier than 8.2.0 for Python 3.9 and newer versions of click for newer versions of Python. Since the changes to CliRunner are backwards-incompatible, we'd need different versions of the test code for different versions of Python. To simplify things, I'll just pin click to the old version for now, and we can properly fix this once we drop support for Python 3.9 later this year.