[DISCO-3754] Add background task to refresh snapshot cache #1105
+147
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herraj
commented
Oct 10, 2025
| assert actual == expected | ||
|
|
||
| assert actual[0] == expected[0] | ||
| assert actual[1] == expected[1] |
Contributor
Author
There was a problem hiding this comment.
These tests would need to be refactored since I refactored the source method to use a queue instead 😅
Herraj
force-pushed
the
disco-3754-add-background-task-to-refresh-snapshot-cache
branch
from
908a0bd to
4348627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3754
Description
PR Review Checklist
[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)┆Issue is synchronized with this Jira Task